> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Przemek Kitszel > Sent: Monday, April 13, 2026 1:53 PM > To: Loktionov, Aleksandr <[email protected]> > Cc: [email protected]; [email protected]; Nguyen, Anthony > L > <[email protected]> > Subject: Re: [Intel-wired-lan] [PATCH iwl-net 2/5] iavf: fix error path in > iavf_request_misc_irq > > On 4/13/26 09:30, Aleksandr Loktionov wrote: > > From: Piotr Gardocki <[email protected]> > > > > When request_irq() fails the interrupt vector was not registered for > > the driver. Calling free_irq() on a vector that was never successfully > > requested triggers a kernel warning. Drop the erroneous free_irq() > > call from the error path. > > > > Fixes: 5eae00c57f5e ("i40evf: main driver core") > > Signed-off-by: Piotr Gardocki <[email protected]> > > Signed-off-by: Aleksandr Loktionov <[email protected]> > > --- > > drivers/net/ethernet/intel/iavf/iavf_main.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c > > b/drivers/net/ethernet/intel/iavf/iavf_main.c > > index dad001a..ab5f5adc 100644 > > --- a/drivers/net/ethernet/intel/iavf/iavf_main.c > > +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c > > @@ -587,7 +587,6 @@ static int iavf_request_misc_irq(struct iavf_adapter > *adapter) > > dev_err(&adapter->pdev->dev, > > "request_irq for %s failed: %d\n", > > adapter->misc_vector_name, err); > > - free_irq(adapter->msix_entries[0].vector, netdev); > > } > > return err; > > } > > Reviewed-by: Przemek Kitszel <[email protected]> > > next time please CC netdev on IWL submissions
Tested-by: Rafal Romanowski <[email protected]>
