________________________________ From: Ruinskiy, Dima Sent: Wednesday, May 13, 2026 9:32 AM To: Loktionov, Aleksandr; Daiki Harada; [email protected]; [email protected]; [email protected] Cc: Nguyen, Anthony L; Kitszel, Przemyslaw; Andrew Lunn; David S. Miller; Eric Dumazet; Jakub Kicinski; Paolo Abeni; Kohei Enju Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 2/2] igc: use napi_schedule_irqoff() instead of napi_schedule()
On 01/04/2026 10:53, Loktionov, Aleksandr wrote: > > >> -----Original Message----- >> From: Intel-wired-lan <[email protected]> On Behalf >> Of Daiki Harada >> Sent: Tuesday, March 31, 2026 12:39 PM >> To: [email protected]; [email protected]; linux- >> [email protected] >> Cc: Nguyen, Anthony L <[email protected]>; Kitszel, >> Przemyslaw <[email protected]>; Andrew Lunn >> <[email protected]>; David S. Miller <[email protected]>; Eric >> Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo >> Abeni <[email protected]>; Daiki Harada <[email protected]>; Kohei >> Enju <[email protected]> >> Subject: [Intel-wired-lan] [PATCH iwl-next v1 2/2] igc: use >> napi_schedule_irqoff() instead of napi_schedule() >> >> Replace napi_schedule() with napi_schedule_irqoff() in the interrupt >> handler path in igc driver Tested on Intel Corporation Ethernet >> Controller I226-V. >> >> Suggested-by: Kohei Enju <[email protected]> >> Signed-off-by: Daiki Harada <[email protected]> >> --- >> drivers/net/ethernet/intel/igc/igc_main.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c >> b/drivers/net/ethernet/intel/igc/igc_main.c >> index 72bc5128d8b8..712605886104 100644 >> --- a/drivers/net/ethernet/intel/igc/igc_main.c >> +++ b/drivers/net/ethernet/intel/igc/igc_main.c >> @@ -5688,7 +5688,7 @@ static irqreturn_t igc_msix_ring(int irq, void >> *data) >> /* Write the ITR value calculated from the previous interrupt. >> */ >> igc_write_itr(q_vector); >> >> - napi_schedule(&q_vector->napi); >> + napi_schedule_irqoff(&q_vector->napi); >> >> return IRQ_HANDLED; >> } >> @@ -6059,7 +6059,7 @@ static irqreturn_t igc_intr_msi(int irq, void >> *data) >> if (icr & IGC_ICR_TS) >> igc_tsync_interrupt(adapter); >> >> - napi_schedule(&q_vector->napi); >> + napi_schedule_irqoff(&q_vector->napi); >> >> return IRQ_HANDLED; >> } >> @@ -6105,7 +6105,7 @@ static irqreturn_t igc_intr(int irq, void *data) >> if (icr & IGC_ICR_TS) >> igc_tsync_interrupt(adapter); >> >> - napi_schedule(&q_vector->napi); >> + napi_schedule_irqoff(&q_vector->napi); >> >> return IRQ_HANDLED; >> } >> -- >> 2.53.0 > > Reviewed-by: Aleksandr Loktionov <[email protected]> > Reviewed-by: Dima Ruinskiy <[email protected]> Tested-By: Moriya Kadosh <[email protected]>
