> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Aleksandr Loktionov > Sent: Wednesday, April 8, 2026 7:11 AM > To: [email protected]; Nguyen, Anthony L > <[email protected]>; Loktionov, Aleksandr > <[email protected]> > Cc: [email protected]; Greenwalt, Paul <[email protected]>; Simon > Horman <[email protected]> > Subject: [Intel-wired-lan] [PATCH net v2] ice: fix ice_init_link() error > return preventing probe > > From: Paul Greenwalt <[email protected]> > > ice_init_link() can return an error status from ice_update_link_info() or > ice_init_phy_user_cfg(), causing probe to fail. > > An incorrect NVM update procedure can result in link/PHY errors, and the > recommended resolution is to update the NVM using the correct procedure. If > the driver fails probe due to link errors, the user cannot update the NVM to > recover. The link/PHY errors logged are non-fatal: they are already annotated as 'not a fatal error if this fails'. > > Since none of the errors inside ice_init_link() should prevent probe from > completing, convert it to void and remove the error check in the caller. All > failures are already logged; callers have no meaningful recovery path for > link init errors. > > Fixes: 5b246e533d01 ("ice: split probe into smaller functions") > Cc: [email protected] > Signed-off-by: Paul Greenwalt <[email protected]> > Signed-off-by: Aleksandr Loktionov <[email protected]> > Reviewed-by: Simon Horman <[email protected]> > --- > v1 -> v2: > - Rename the now-unused goto label err_init_link to err_deinit_pf_sw > to better describe the cleanup it performs (Simon Horman). > > drivers/net/ethernet/intel/ice/ice_main.c | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-)
Tested-by: Alexander Nowlin <[email protected]>
