> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Loktionov, Aleksandr > Sent: Wednesday, April 29, 2026 11:18 AM > To: Vincent Chen <[email protected]>; Nguyen, Anthony L > <[email protected]>; Kitszel, Przemyslaw > <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected] > Subject: Re: [Intel-wired-lan] [PATCH 1/2] ice: allow creating VFs when > !CONFIG_ICE_SWITCHDEV > > > > > -----Original Message----- > > From: Intel-wired-lan <[email protected]> On Behalf > > Of Vincent Chen via Intel-wired-lan > > Sent: Wednesday, April 29, 2026 8:51 AM > > To: Nguyen, Anthony L <[email protected]>; Kitszel, > > Przemyslaw <[email protected]> > > Cc: [email protected]; [email protected]; [email protected]; > > [email protected]; [email protected]; [email protected]; > > [email protected]; [email protected] > > Subject: [Intel-wired-lan] [PATCH 1/2] ice: allow creating VFs when > > !CONFIG_ICE_SWITCHDEV > > > > Currently ice_eswitch_attach_vf() is called unconditionally in > > ice_start_vfs(), which causes VF creation to fail when > > CONFIG_ICE_SWITCHDEV is not defined. > > > > Fix this by adding switchdev mode checks at the call sites before > > calling ice_eswitch_attach_vf(), consistent with how > > ice_eswitch_attach_sf() is already handled in ice_devlink_port_new(). > > This is similar to commit aacca7a83b97 ("ice: allow creating VFs for > > !CONFIG_NET_SWITCHDEV") which fixed the same issue for the previous > > ice_eswitch_configure() API. > > > > Signed-off-by: Vincent Chen <[email protected]> > > --- > > drivers/net/ethernet/intel/ice/ice_sriov.c | 14 ++++++++------ > > drivers/net/ethernet/intel/ice/ice_vf_lib.c | 3 ++- > > 2 files changed, 10 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/net/ethernet/intel/ice/ice_sriov.c > > b/drivers/net/ethernet/intel/ice/ice_sriov.c > > index 843e82fd3bf9..6a0b724e46f9 100644 > > --- a/drivers/net/ethernet/intel/ice/ice_sriov.c > > +++ b/drivers/net/ethernet/intel/ice/ice_sriov.c > > @@ -484,12 +484,14 @@ static int ice_start_vfs(struct ice_pf *pf)
Tested-by: Rafal Romanowski <[email protected]>
