> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Marcin Szycik > Sent: Thursday, May 21, 2026 4:50 AM > To: [email protected] > Cc: [email protected]; Penigalapati, Sandeep > <[email protected]>; S, Ananth <[email protected]>; > [email protected]; Czapnik, Lukasz <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-next v4 10/10] ice: use ACL for ntuple > rules that conflict with FDir > > From: Lukasz Czapnik <[email protected]> > > Flow Director can keep only one input set per flow type. After ACL support > was added for ethtool ntuple rules, the driver still only selected ACL for > rules with partial masks. > > That leaves a gap for rules with full masks that still require a different > input set than the one already programmed for Flow Director. Such rules go > through the FDir path, build a different extraction sequence and > then fail > because the existing FDir profile cannot be reused. > > Detect this case before programming the rule. Build the candidate IP flow > segment, compare it with the active non-tunneled FDir profile and, when the > input sets differ, offload the rule through ACL if ACL is > available. > > Refactor the IP flow segment setup into a helper so the same logic can be > used both by the extraction-sequence configuration path and by the conflict > check. > > Signed-off-by: Lukasz Czapnik <[email protected]> > --- > v3: > * Include flex fields in test_seg to avoid false conflict detection > * Skip conflict check early for ETHER_FLOW > v2: > * Add this patch > --- > .../ethernet/intel/ice/ice_ethtool_ntuple.c | 168 +++++++++++++----- > 1 file changed, 121 insertions(+), 47 deletions(-)
Tested-by: Alexander Nowlin <[email protected]>
