> > Isn't a cable length of 0 also unexpected?
> > 
> > How does this patch actually make the situation better?
> > 
> Uninitialized variables may be initialized to 0 by the system, explicit 
> initialization
> is performed to avoid accidents. 

That is still not an explanation why 0 is better.

Maybe you want to change this from a void function to something which
can return an error code?

But also consider the history of this driver. When did anybody do any
serious development work on it? Does it makes sense to do work on it?
I assume you have the hardware and can test the changes you are
making.

        Andrew

Reply via email to