On Wed, Jul 08, 2026 at 07:22:02PM +0200, Maciej Fijalkowski wrote: > On Wed, Jul 08, 2026 at 04:04:56PM +0100, Simon Horman wrote: > > This is an AI-generated review of your patch. The human sending this > > email has considered the AI review valid, or at least plausible. > > Full review at: https://sashiko.dev > > --- > > i40e: avoid null ptr dereference in i40e_ptp_stop() > > > > Check if main_vsi is not null before calling dev_info() to avoid a null > > pointer dereference when i40e_vsi_clear() frees the main VSI during rebuild. > > > > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_ptp.c > > > b/drivers/net/ethernet/intel/i40e/i40e_ptp.c > > > index ff62b5f2c8150..ca93df4d67859 100644 > > > --- a/drivers/net/ethernet/intel/i40e/i40e_ptp.c > > > +++ b/drivers/net/ethernet/intel/i40e/i40e_ptp.c > > > @@ -1556,8 +1556,9 @@ void i40e_ptp_stop(struct i40e_pf *pf) > > > if (pf->ptp_clock) { > > > ptp_clock_unregister(pf->ptp_clock); > > > pf->ptp_clock = NULL; > > > - dev_info(&pf->pdev->dev, "%s: removed PHC on %s\n", __func__, > > > - main_vsi->netdev->name); > > > + if (main_vsi) > > > + dev_info(&pf->pdev->dev, "%s: removed PHC on %s\n", > > > __func__, > > > + main_vsi->netdev->name); > > > > [Severity: High] > > This isn't a bug introduced by this patch, but this lockless check appears > > to introduce a time-of-check to time-of-use race condition. > > Thanks Simon I saw these, however since all of the issues are classified > as pre-existing issues IMHO these changes are okay to be taken and then > we could go with another round of fixes.
Yes, agreed. Sorry about the noise.
