igb_runtime_resume() calls __igb_resume() with rpm=true, which
skips rtnl_lock() to avoid deadlocks. On that path __igb_open()
-> igb_configure() -> igb_setup_mrqc() -> igb_write_rss_key()
runs without rtnl held, so ASSERT_RTNL() fires a false-positive
WARN on every runtime resume. Drop it.

Fixes: dfaf57ef99cf ("igb: prepare for RSS key get/set support")
Signed-off-by: Takashi Kozu <[email protected]>
---
 drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c 
b/drivers/net/ethernet/intel/igb/igb_ethtool.c
index 65014a54a6d1..4eb586f9af99 100644
--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
@@ -3031,8 +3031,6 @@ void igb_write_rss_key(struct igb_adapter *adapter)
 {
        struct e1000_hw *hw = &adapter->hw;
 
-       ASSERT_RTNL();
-
        for (int i = 0; i < IGB_RSS_KEY_SIZE / 4; i++) {
                u32 val = get_unaligned_le32(&adapter->rss_key[i * 4]);
 
-- 
2.54.0

Reply via email to