> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Dawei > Feng > Sent: 16 June 2026 21:28 > To: Nguyen, Anthony L <[email protected]> > Cc: Kitszel, Przemyslaw <[email protected]>; Andrew Lunn > <[email protected]>; David S . Miller <[email protected]>; Eric Dumazet > <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni > <[email protected]>; [email protected]; > [email protected]; [email protected]; [email protected]; > Dawei Feng <[email protected]>; [email protected] > Subject: [Intel-wired-lan] [PATCH net v2] ice: fix memory leak in > ice_lbtest_prepare_rings() > > ice_lbtest_prepare_rings() frees Rx rings only when > ice_vsi_start_all_rx_rings() fails. If ice_vsi_setup_rx_rings() fails after > allocating some descriptors, or if ice_vsi_cfg_lan() fails after the Rx rings > were prepared, the function reaches the Tx cleanup path without releasing the > initialized Rx resources. > > Fix this by adding separate unwind paths for Rx setup failure and LAN > configuration failure. The Rx setup failure path releases the partially > prepared Rx rings before freeing Tx rings, while later failures first undo > the LAN Tx configuration and then release the Rx rings in reverse setup order. > > The bug was first flagged by an experimental analysis tool we are developing > for kernel memory-management bugs while analyzing v6.13-rc1. The tool is > still under development and is not yet publicly available. Manual inspection > confirms that the bug is still present in v7.1-rc7. > > An x86_64 allyesconfig build showed no new warnings. As we do not have an > Intel E800 Series adapter available to run the ethtool offline loopback > selftest, no runtime testing was able to be performed. > > Fixes: 0e674aeb0b77 ("ice: Add handler for ethtool selftest") > Cc: [email protected] > Signed-off-by: Dawei Feng <[email protected]> > --- > Changes in v2: > - Fix cleanup order > > drivers/net/ethernet/intel/ice/ice_ethtool.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >
Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)
