On 8/24/26 20:14, Jakub Kicinski wrote:
> On Fri, 21 Aug 2026 10:28:47 -0700 Stanislav Fomichev wrote:
>>>> I do agree that a better idea is to probably do these checks during control
>>>> paths, but it's a bit more involved (and not sure if it's possible? if we
>>>> have a bunch of xsk sockets and we change that max_sdu, do we go over all
>>>> sockets on the system somehow?). My main motivation with this patch was
>>>> to make our LLM reviewers less chatty about preexisting issues.
>>>
>>> I hear you, however I feel like we do not know this driver too much and
>>> probably we don't have a HW to test out such changes, so maybe let us try
>>> to fix existing behavior?
>>
>> Let's definitely fix it properly if you have better ideas. But since we
>> don't have HW, I'm not super confident doing anything sophisticated
>> myself :-D
>
> Let me take the first 2 patches and leave the stmmac for later.
> I don't think anyone involved care particularly deeply here.
>
> Maxime said he bought a bunch of relevant HW. If we finally wrap
> the AF_XDP tests into driver runtime he should be able to help us...
Indeed, I haven't started looking into the AF_XDP (and XDP in general) on
stmmac, lots of fixes lately on the subject so I'll get there eventually :)
I'm currently plumbing the driver selftest on my setup (ethtool -t) and just
runnign this uncovers lots of issues al lover the place, once this
passes I'll get on the kselftests and see what we can do on this.
Maxime
