> -----Original Message----- > From: Jakub Kicinski <[email protected]> > Sent: Thursday, August 20, 2026 7:02 PM > To: Nguyen, Anthony L <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; Jakub Kicinski <[email protected]>; Kitszel, > Przemyslaw <[email protected]>; [email protected]; Shelton, > > Benjamin H <[email protected]> > Subject: [PATCH iwl] eth: ice: don't dereference pointers from TP_printk() > > After forwarding net-next during the v7.3 merge window we started > seeing: > > TRACE EVENT ERROR: Event ice_tx_dim_work has double dereference in > TP_printk: REC->q_vector->tx.tx_ring->q_index > WARNING: kernel/trace/trace_events.c:420 at > test_double_dereference.cold+0x39/0x4b > > this is due to extra checks added in tracing subsystem in commit b5cc230af5e5 > ("tracing: Warn when an > event dereferences a pointer in TP_printk()"). > > Printing happens long after the event was recorded, by which point the > pointers may be invalid (the ring > or the dim instance). > Copy the eight scalars into the event instead. > > Fixes: 3089cf6d3caa ("ice: add tracepoints") > Signed-off-by: Jakub Kicinski <[email protected]> > --- > CC: [email protected] > CC: [email protected] > CC: [email protected] > CC: [email protected] > --- > drivers/net/ethernet/intel/ice/ice_trace.h | 64 ++++++++++++++-------- > 1 file changed, 42 insertions(+), 22 deletions(-)
Tested-by: Alexander Nowlin <[email protected]>
