> -----Original Message----- > From: Yury Norov <[email protected]> > Sent: Monday, September 7, 2026 11:55 PM > To: Andrew Lunn <[email protected]>; Heiner Kallweit > <[email protected]>; Russell King <[email protected]>; Raju Rangoju > <[email protected]>; Prashanth Kumar K R > <[email protected]>; Nguyen, Anthony L > <[email protected]>; Kitszel, Przemyslaw > <[email protected]>; Jian Shen <[email protected]>; Jijie > Shao <[email protected]>; David S. Miller <[email protected]>; Eric > Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo > Abeni <[email protected]>; [email protected]; > [email protected]; [email protected]; linux- > [email protected] > Cc: Yury Norov <[email protected]>; Yury Norov <[email protected]>; > Rasmus Villemoes <[email protected]>; Andrew Morton <akpm@linux- > foundation.org> > Subject: [PATCH 4/9] ixgbe: use linkmode_and() return value in > ixgbe_get_eee_fw() > > Use the return value of linkmode_and() to determine whether EEE is active > instead of scanning the common link mode bitmap separately. > > Signed-off-by: Yury Norov <[email protected]> > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c > b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c > index 36e43b5e88d1..a7b7f89f29e4 100644 > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c > @@ -3751,8 +3751,7 @@ ixgbe_get_eee_fw(struct ixgbe_adapter *adapter, > struct ethtool_keee *edata) > edata->eee_enabled = !linkmode_empty(edata->advertised); > edata->tx_lpi_enabled = edata->eee_enabled; > > - linkmode_and(common, edata->advertised, edata->lp_advertised); > - edata->eee_active = !linkmode_empty(common); > + edata->eee_active = linkmode_and(common, edata->advertised, > +edata->lp_advertised); > > return 0; > } > -- > 2.53.0
Reviewed-by: Sergey Temerkhanov <[email protected]>
