> -----Original Message----- > From: Keller, Jacob E <[email protected]> > Sent: Tuesday, August 25, 2026 3:53 PM > To: Intel Wired LAN <[email protected]> > Cc: [email protected]; Machnikowski, Maciej > <[email protected]>; Nguyen, Anthony L > <[email protected]>; Korba, Przemyslaw <[email protected]>; > Nitka, Grzegorz <[email protected]>; Oros, Petr <[email protected]>; > Nowlin, Alexander <[email protected]>; Bross, Kevin > <[email protected]>; Cavatur, Ranjit <[email protected]>; Keller, > Jacob E <[email protected]> > Subject: [PATCH iwl-net v2 02/14] ice: fix removal of PTP timestamp tracker > during reset > > Commit 7a25fe5cd5fb ("ice: stop destroying and reinitalizing Tx tracker > during reset") intended to modify the PTP reset flow of the driver so that it > stopped calling ice_ptp_reset_tx_tracker() during teardown and stopped > calling ice_ptp_init_tx_*() during rebuild. > > Unfortunately, the commit only removed the calls to ice_ptp_init_tx_*(). > This fixed a memory leak in PF reset. However, now a CORE or GLOBAL reset > will leave the device unable to initiate Tx timestamp requests indefinitely. > > In practice the CORE and GLOBAL resets rarely happen in production > environments, which explains why this has not been caught until now. > However, it is trivial to verify by triggering the reset from userspace via > ethtool. For ice the following command will trigger a GLOBAL reset: > > $ ethtool --reset eno8303np0 irq-shared dma-shared filter-shared \ > offload-shared ram-shared mac-shared phy-shared > > This was found by Sashiko review during feedback for an unrelated change. > > Closes: > https://sashiko.dev/#/patchset/20260821-jk-e825c-minimized-fixes-v1-0-9d0731eb4858%40intel.com?part=8 > Fixes: 7a25fe5cd5fb ("ice: stop destroying and reinitalizing Tx tracker > during reset") > Signed-off-by: Jacob Keller <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice_ptp.c | 2 -- > 1 file changed, 2 deletions(-)
Tested-by: Alexander Nowlin <[email protected]>
