> -----Original Message----- > From: Sergey Temerkhanov <[email protected]> > Sent: Monday, August 31, 2026 7:50 AM > To: [email protected] > Cc: [email protected] > Subject: [PATCH iwl-next v5 3/6] ice: dpll: Use switch statements to handle > pin states > > Use switch statements to handle pin states to make the code more > readable. This also makes this code more future-proof, should any > new states appear. > > This also changes how direction-mismatched state requests are handled in > ice_dpll_sma_pin_state_set(). Previously, requesting CONNECTED on an > INPUT-direction SMA pin or SELECTABLE on an OUTPUT-direction pin would > fall through to ice_dpll_pin_disable() and return success. After this > change those requests return -EINVAL without issuing a firmware command. > Because the DPLL netlink core does not filter pin states by direction > before calling the driver, this is a user-visible netlink API change. > > Signed-off-by: Sergey Temerkhanov <[email protected]> > Reviewed-by: Aleksandr Loktionov <[email protected]> > Reviewed-by: Przemyslaw Korba <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice_dpll.c | 72 ++++++++++++++++++----- > 1 file changed, 57 insertions(+), 15 deletions(-)
Tested-by: Sunitha Mekala <[email protected]> (A Contingent worker at Intel)
