On Tue, Sep 15, 2026 at 02:55:19PM +0200, Aleksandr Loktionov wrote: > From: Jakub Staniszewski <[email protected]> > > Correct the logic in ndo_fdb_del() to align with other drivers in > upstream. The condition was inverted — it was rejecting permanent > (NUD_PERMANENT) MAC addresses while allowing non-permanent ones to be > deleted, which is the opposite of the intended behavior. > > The correct logic is to reject deletion of non-permanent entries, > mirroring the fix applied to ndo_dflt_fdb_del() in commit 645359930231 > ("rtnetlink: Fix inverted check in ndo_dflt_fdb_del()"). > > Also add is_link_local_ether_addr() to the unicast branch of > ice_fdb_del() to mirror ice_fdb_add(), which already handles link-local > addresses as unicast via dev_uc_add_excl(). Without this, a link-local > address added via ice_fdb_add() would fall through to dev_mc_del() on > deletion and fail to be removed. > > Fixes: e94d4478669357cd ("ice: Implement filter sync, NDO operations and bump > version") > Cc: [email protected] > Signed-off-by: Jakub Staniszewski <[email protected]> > Signed-off-by: Aleksandr Loktionov <[email protected]>
Reviewed-by: Simon Horman <[email protected]>
