> -----Original Message-----
> From: Sasha Neftin <[email protected]>
> Sent: Tuesday, September 22, 2026 12:35 PM
> To: [email protected]
> Subject: [iwl-net, v1] igc: Fix typo in IGC_NO_QUEUE macro definition
> 
> Correct the macro name from IGC_N0_QUEUE (using digit '0') to
> IGC_NO_QUEUE (using letter 'O') in igc_defines.h and update its usage
> in igc_main.c.
> 
> Fixes: 16ecd8d9af26 ("igc: Remove the obsolete workaround")
> Signed-off-by: Sasha Neftin <[email protected]>
> ---
>  drivers/net/ethernet/intel/igc/igc_defines.h | 2 +-
>  drivers/net/ethernet/intel/igc/igc_main.c    | 8 ++++----
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h
> b/drivers/net/ethernet/intel/igc/igc_defines.h
> index 3f504751c2d9..ab55b88d4d96 100644
> --- a/drivers/net/ethernet/intel/igc/igc_defines.h
> +++ b/drivers/net/ethernet/intel/igc/igc_defines.h
> @@ -721,7 +721,7 @@
>  #define IGC_LP_EEE_1000BT_MASK       BIT(2)
>  #define IGC_LP_EEE_100BT_MASK        BIT(1)
> 
> -#define IGC_N0_QUEUE         -1
> +#define IGC_NO_QUEUE         -1
> 
>  #define IGC_MAX_MAC_HDR_LEN  127
>  #define IGC_MAX_NETWORK_HDR_LEN      511
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c
> b/drivers/net/ethernet/intel/igc/igc_main.c
> index 1fb5f3cbe93c..ba75350291f5 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -4223,8 +4223,8 @@ static void igc_assign_vector(struct
> igc_q_vector *q_vector, int msix_vector)  {
>       struct igc_adapter *adapter = q_vector->adapter;
>       struct igc_hw *hw = &adapter->hw;
> -     int rx_queue = IGC_N0_QUEUE;
> -     int tx_queue = IGC_N0_QUEUE;
> +     int rx_queue = IGC_NO_QUEUE;
> +     int tx_queue = IGC_NO_QUEUE;
> 
>       if (q_vector->rx.ring)
>               rx_queue = q_vector->rx.ring->reg_idx; @@ -4233,11
> +4233,11 @@ static void igc_assign_vector(struct igc_q_vector
> *q_vector, int msix_vector)
> 
>       switch (hw->mac.type) {
>       case igc_i225:
> -             if (rx_queue > IGC_N0_QUEUE)
> +             if (rx_queue > IGC_NO_QUEUE)
>                       igc_write_ivar(hw, msix_vector,
>                                      rx_queue >> 1,
>                                      (rx_queue & 0x1) << 4);
> -             if (tx_queue > IGC_N0_QUEUE)
> +             if (tx_queue > IGC_NO_QUEUE)
>                       igc_write_ivar(hw, msix_vector,
>                                      tx_queue >> 1,
>                                      ((tx_queue & 0x1) << 4) + 8);
> --
> 2.43.0

Reviewed-by: Aleksandr Loktionov <[email protected]>

Reply via email to