Re: [PATCH iwl-net v3] ice: fix LLDP AQ filter fallback not working on E82x and E830 hardware

[Tony Nguyen]

On 9/18/2026 6:32 AM, Aleksandr Loktionov wrote:

...

diff --git a/drivers/net/ethernet/intel/ice/ice_common.c 
b/drivers/net/ethernet/intel/ice/ice_common.c
index 0463310..b31be52 100644
--- a/drivers/net/ethernet/intel/ice/ice_common.c
+++ b/drivers/net/ethernet/intel/ice/ice_common.c
@@ -6375,15 +6375,28 @@ ice_aq_set_lldp_mib(struct ice_hw *hw, u8 mib_type, 
void *buf, u16 buf_size,
  /**
   * ice_fw_supports_lldp_fltr_ctrl - check NVM version supports lldp_fltr_ctrl
   * @hw: pointer to HW struct
+ *
+ * Check if firmware supports the LLDP filter control feature (AQ command
+ * 0x0A0A). Different hardware families require different minimum firmware
+ * API versions:
+ * - E810 and E82x: API version >= 1.7.1
+ * - E830: API version >= 1.7.11
   */
  bool ice_fw_supports_lldp_fltr_ctrl(struct ice_hw *hw)
  {
-       if (hw->mac_type != ICE_MAC_E810)
+       switch (hw->mac_type) {
+       case ICE_MAC_E830:
+               return ice_is_fw_api_min_ver(hw, ICE_FW_API_LLDP_FLTR_MAJ_E830,
+                                            ICE_FW_API_LLDP_FLTR_MIN_E830,
+                                            ICE_FW_API_LLDP_FLTR_PATCH_E830);
+       case ICE_MAC_E810:
+       case ICE_MAC_GENERIC:
+               return ice_is_fw_api_min_ver(hw, ICE_FW_API_LLDP_FLTR_MAJ,
+                                            ICE_FW_API_LLDP_FLTR_MIN,
+                                            ICE_FW_API_LLDP_FLTR_PATCH);

Sashiko on a previous version of this patch reported:

"
Does this switch statement intentionally omit ICE_MAC_GENERIC_3K_E825?
Since E825 devices use ICE_MAC_GENERIC_3K_E825, they will fall through 
to the
default case and return false. This causes the fallback function
ice_lldp_fltr_add_remove() to return -EOPNOTSUPP on E825 hardware, leaving
these devices without an LLDP filter.
Would it be better to include case ICE_MAC_GENERIC_3K_E825 here, or use the
ice_is_generic_mac() helper?
"

I believe ICE_MAC_GENERIC_3K_E825 also supports this and should be included?

Thanks,
Tony

+       default:
                return false;
-
-       return ice_is_fw_api_min_ver(hw, ICE_FW_API_LLDP_FLTR_MAJ,
-                                    ICE_FW_API_LLDP_FLTR_MIN,
-                                    ICE_FW_API_LLDP_FLTR_PATCH);
+       }
  }