> skb_condense() pulls all of the frag data into the head and then sets > truesize to cover just the head, but it ignores the return value of > __pskb_pull_tail(). If the pull failed, the frags would still be > attached and truesize would undercount them. > > It can't fail today. The caller has checked that the head has room, > that the skb isn't cloned and that the frags are readable, and pulling > all of data_len eats every frag_list skb whole, so nothing is > allocated. Check the result anyway and leave the skb alone on > failure, so this stays correct if any of that changes. Use > __skb_linearize(), which is what this pull is. > > Assisted-by: LLM > Signed-off-by: Josef Bacik <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review ยท https://sashiko.dev/#/patchset/20261007-b4-pskb-pull-tail-drivers-v1-0-9512b0fb9...@toxicpanda.com?part=9
