On 10/10/2026 2:57 AM, Sasha Neftin wrote:
The break after "return IGC_XDP_REDIRECT;" in the XDP_REDIRECT case can never be reached. Remove it. No functional change.
Hi Sasha, Thanks for the patch, but we already have it queued up: https://lore.kernel.org/intel-wired-lan/[email protected]/
Assisted-by: Claude:claude-sonnet-5-5
Also, these should "Assisted-by: LLM" now. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=816d9992d9ed434ec52cfbd63080d518e535a41b Thanks, Tony
Signed-off-by: Sasha Neftin <[email protected]> --- drivers/net/ethernet/intel/igc/igc_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c index 1fb5f3cbe93c..3b7dd104d8d9 100644 --- a/drivers/net/ethernet/intel/igc/igc_main.c +++ b/drivers/net/ethernet/intel/igc/igc_main.c @@ -2525,7 +2525,6 @@ static int __igc_xdp_run_prog(struct igc_adapter *adapter, if (xdp_do_redirect(adapter->netdev, xdp, prog) < 0) goto out_failure; return IGC_XDP_REDIRECT; - break; default: bpf_warn_invalid_xdp_action(adapter->netdev, prog, act); fallthrough;
