Re: [PATCH iwl-next v2 1/2] ice: parse external Root of Trust capability

[Tomasz Lichwala]

On 8.10.2026 16:14, Aleksandr Loktionov wrote:
> diff --git a/drivers/net/ethernet/intel/ice/ice_common.c 
> b/drivers/net/ethernet/intel/ice/ice_common.c
> index 6bde8f5..f1262d9 100644
> --- a/drivers/net/ethernet/intel/ice/ice_common.c
> +++ b/drivers/net/ethernet/intel/ice/ice_common.c
> @@ -2484,6 +2484,12 @@ ice_parse_common_caps(struct ice_hw *hw, struct 
> ice_hw_common_caps *caps,
>       case LIBIE_AQC_CAPS_TX_SCHED_TOPO_COMP_MODE:
>               caps->tx_sched_topo_comp_mode_en = (number == 1);
>               break;
> +     case LIBIE_AQC_CAPS_EXTERNAL_PQC_ROT_PRESENT:
> +             caps->external_pqc_rot_present = (number == 1);
> +             caps->external_pqc_rot_invalid = (number != 0 && number != 1);

Nit: plain assignment, not sticky - if firmware ever emitted this capability 
entry twice in one response, a later valid value would silently clear a prior 
"invalid" verdict. Consider |= if "fail closed" is meant to be strict.

> +             ice_debug(hw, ICE_DBG_INIT, "%s: external_pqc_rot = %u\n",
> +                       prefix, number);
> +             break;
>       default:
>               /* Not one of the recognized common capabilities */
>               found = false;

Thanks,
Tomasz