> -----Original Message----- > From: Simon Horman <[email protected]> > Sent: Friday, September 18, 2026 5:12 PM > To: Loktionov, Aleksandr <[email protected]> > Cc: [email protected]; Nguyen, Anthony L > <[email protected]>; [email protected] > Subject: Re: [PATCH iwl-net v2 2/5] iavf: fix error path in > iavf_request_misc_irq > > On Tue, Sep 15, 2026 at 02:55:48PM +0200, Aleksandr Loktionov wrote: > > From: Piotr Gardocki <[email protected]> > > > > When request_irq() fails the interrupt vector was not registered for > > the driver. Calling free_irq() on a vector that was never successfully > > requested triggers a kernel warning. Drop the erroneous free_irq() > > call from the error path. > > > > Fixes: 5eae00c57f5e ("i40evf: main driver core") > > Cc: [email protected] > > Signed-off-by: Piotr Gardocki <[email protected]> > > Signed-off-by: Aleksandr Loktionov <[email protected]> > > This feels more like a clean-up than a bug fix. > > But regardless, the change itself looks good to me: > > Reviewed-by: Simon Horman <[email protected]> > > ...
Tested-by: Rafal Romanowski <[email protected]>
