On 10/27/2026 6:15 AM, Maciej Fijalkowski wrote: > On Tue, Oct 27, 2026 at 02:14:40PM +0100, Maciej Fijalkowski wrote: >> On Tue, Oct 27, 2026 at 02:56:07PM +0200, Magnus Karlsson wrote: >>> On Tue, 27 Oct 2026 at 14:43, Eric Dumazet <[email protected]> wrote: >>>> >>>> Le mar. 27 oct. 2026 à 13:15, Magnus Karlsson >>>> <[email protected]> a écrit : >>>>> >>>>> That USO works for 64-bit systems is just pure luck. Currently, the >>>>> computation of the UDP segmentation header is performed using sizeof() >>>>> a pointer instead of the sizeof() the UDP header that the pointer >>>>> points to. Since the UDP header happens to be 8 bytes long and a >>>>> pointer is 8 bytes long on a 64-bit system, this works on all those >>>>> systems. But no such luck for anyone using a 32-bit system as 8 bytes >>>>> != 4 bytes. So fix this by using sizeof() the UDP header that the >>>>> pointer points to instead. >>>>> >>>>> This was found by an LLM while implementing something else that used USO. >>>>> >>>>> Fixes: c91a4f9feb67a199c2 ("add support for UDP Segmentation Offload") >>>> >>>> Missing prefix? This was really: >>>> >>>> Fixes: c91a4f9feb67 ("iavf: add support for UDP Segmentation Offload") >>> >>> You are correct on both accounts/patches. Do not know why I missed this, >>> sorry. >>> >>> Do you want a v2 with this added? >> >> Current policy is that you need to wait 24h with posting next revisions. >> Eric marked it as 'changes requested' so yes, you need a v2. >> >> You can add my review tag as well, thanks for auditing intel drivers >> against this bug. > > Also I believe currently we should not CC netdev on iwl submissions. > Przemek, Tony, correct me if I'm wrong. > Yes. We historically were cross-posting Intel Wired LAN to netdev, but as of recently we agreed with Jakub to stop doing that since the list was being overloaded, and it wasn't promoting review from folks outside Intel anyways.
Please submit a v2 with these fixes to the Intel Wired LAN list. No need to include netdev.
