On 11/2/26 12:47 AM, Ingyu Jang wrote:
All implementations of the EEPROM init_params() operation always
return 0, so the error checks on its return value in ixgbe_sw_init()
and the E610 NVM helpers never trigger.
Make init_params() return void and remove the dead checks.
Link: https://lore.kernel.org/all/[email protected]
Signed-off-by: Ingyu Jang <[email protected]>
thank you for reaching out,
in general we don't want trivial refactors unless as a part of bigger
contribution
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#clean-up-patches
especially now, we are drowned in patches, so this particular one would
be on the very bottom of the priority list
---
.../net/ethernet/intel/ixgbe/ixgbe_common.c | 4 +--
.../net/ethernet/intel/ixgbe/ixgbe_common.h | 2 +-
drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 29 +++++--------------
drivers/net/ethernet/intel/ixgbe/ixgbe_e610.h | 2 +-
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 +---
drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 2 +-
drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c | 4 +--
drivers/net/ethernet/intel/ixgbe/ixgbe_x540.h | 2 +-
drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 4 +--
9 files changed, 16 insertions(+), 38 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c
b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c
index 3ea6765f9c5d8..ab2c0818f2417 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c
@@ -857,7 +857,7 @@ int ixgbe_led_off_generic(struct ixgbe_hw *hw, u32 index)
* Initializes the EEPROM parameters ixgbe_eeprom_info within the
* ixgbe_hw struct in order to set up EEPROM access.
**/
-int ixgbe_init_eeprom_params_generic(struct ixgbe_hw *hw)
+void ixgbe_init_eeprom_params_generic(struct ixgbe_hw *hw)
{
struct ixgbe_eeprom_info *eeprom = &hw->eeprom;
u32 eec;
@@ -895,8 +895,6 @@ int ixgbe_init_eeprom_params_generic(struct ixgbe_hw *hw)
hw_dbg(hw, "Eeprom params: type = %d, size = %d, address bits:
%d\n",
eeprom->type, eeprom->word_size, eeprom->address_bits);
}
-
- return 0;
}
[...]
