> -----Original Message----- > From: Petr Oros <[email protected]> > Sent: Friday, October 2, 2026 6:08 AM > To: [email protected] > Cc: Oros, Petr <[email protected]>; Nguyen, Anthony L > <[email protected]>; Kitszel, Przemyslaw > <[email protected]>; Andrew Lunn <[email protected]>; David S. > Miller <[email protected]>; Eric Dumazet <[email protected]>; Jakub > Kicinski <[email protected]>; Paolo Abeni <[email protected]>; Lobakin, > Aleksander <[email protected]>; Alexei Starovoitov > <[email protected]>; Daniel Borkmann <[email protected]>; Jesper Dangaard > Brouer <[email protected]>; John Fastabend <[email protected]>; > Stanislav Fomichev <[email protected]>; Henry Tieman > > <[email protected]>; Anirudh Venkataramanan > <[email protected]>; Michal Swiatkowski > <[email protected]>; Jesse Brandeburg <[email protected]>; > Preethi Banala <[email protected]>; Kiran Patil > <[email protected]>; Dan Nowlin <[email protected]>; Stephen Hemminger > <[email protected]>; [email protected]; > [email protected]; [email protected] > Subject: [PATCH iwl-net 03/10] ice: stop the LAN Tx queues when > ice_vsi_open() fails > > ice_vsi_cfg_lan() adds the LAN (and XDP) Tx queues to the scheduler and > enables them in hardware. If anything after it fails in ice_vsi_open(), for > example requesting the MSI-X vectors, the error path only frees the ring > memory and leaves the queues configured. Every following open then fails to > add the same queues again and the netdev can not be brought up until the > driver is reloaded: > > ice 0000:04:00.2: Failed to set LAN Tx queue context, error: -5 > ice 0000:04:00.2 enp4s0f2np2: Failed to open VSI 0x0010 on switch 0x0002 > > Stop the Tx queues on the error paths that run after ice_vsi_cfg_lan(). > The ice_up_complete() failure path already does it through ice_down(), so let > it skip the new step. > > There is no i40e counterpart of this fix, i40e does not add its Tx queues > through the admin queue. It was found while verifying the previous patch. > With the IRQ unwind fixed the warnings were gone, but the netdev still could > not be opened again after the forced request_irq failure. > > Fixes: cdedef59deb0 ("ice: Configure VSIs for Tx/Rx") > Assisted-by: LLM > Signed-off-by: Petr Oros <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice_main.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-)
Tested-by: Alexander Nowlin <[email protected]>
