Eike Rathke wrote:
Hi Frank,

On Mon, May 29, 2006 at 15:33:48 +0200, Frank Schönheit wrote:

What about

  struct ApprovalOrVeto_OrAnyBetterName
  {
    boolean    IsVeto;
    string     Veto;
    any        Reason;
    XInterface Context;
  };

That struct would have to be created, though with empty members, even in
the all-good-no-veto case. Depending on the scenario this may cause
significant unnecessary overhead with mass objects. Shouldn't we better
have a simple boolean return instead and explicitly act on a veto?

    if (!listener->approve())
    {
        Veto_OrAnyBetterName aReason = listener->getVetoReason();
        ...
    }

This requires a statefull listener implementation, which is very problematic (what happens when a second call to approve comes before the call to getVetoReason, either on a different thread, or recursively on the same thread if listener.approve internally needs to make calls to somewhere else?)

-Stephan

  Eike

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to