Hi Michael, > so i would be especially interested in input from people who would > like to use ODF metadata: does this API do what you need?
I don't know :), but have some other feedback (always "IMO") - Pair< T, U > clearly belongs into css.beans (yes, that's nasty, since you need to add udkapi to your CWS then :) - css.rdf is perfectly okay for the types - I wouldn't put them below another module, finally, the interfaces can probably be used for other purposes later. - Re: "FIXME: hmmm, does it make sense to allow creating arbitrary blank nodes?" Not sure about "blank" here. Mozilla's API, which I used some year ago, has something like "createAnonymousNode", IIRC (My memory might *completely* fool me here). If that's a same as a "blank" node, then I think such a thing might be useful - at least I used anonymous nodes in my only encounter with RDF so far. - Re "FIXME: would a base RDFException make sense?" I tend to answering "no" here, since transforming the question would be "Are there use cases where a client would be interested in catching the RDFException only, without evaluating the actual derived exception?" Since *all* information in all the RDF*Exceptions is in their type, and not in their members, I suppose there are no such use cases. - RDF*Exception; If they all are in the namespace css.rdf, then the RDF in the name might be considered superfluous. For instance, the RDFRepositoryException could better be a css.rdf.(Illegal)RepositoryException, and the like. - XRDFRepository::importGraph: I'd suggest throwing a WrappedTargetException here, instead of the IOException. IMO (but that might be only me) this better separates errors in the stream usage (i.e. an externally-supplied component) from "internal" errors, and errors in the arguments. Similar for other methods of this interface. Ciao Frank -- - Frank Schönheit, Software Engineer [EMAIL PROTECTED] - - Sun Microsystems http://www.sun.com/staroffice - - OpenOffice.org Base http://dba.openoffice.org - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
