Hi Niklas,

>> In the concrete case, I think replacing the enum with an (extensible)
>> constant group is better than introducing the FilterOperator2, which
>> just adds clutter to the API.
> 
> The FilterOperator2 constants group contains the old and new operators, 
> the TableFilterField2 struct contains an integer instead of the 
> FilterOperator enum, and the XSheetFilterDescriptor2 interface can be 
> used instead of XSheetFilterDescriptor.
> 
> So, "replacing the enum with an constant group" is exactly what was 
> done, keeping the old types for compatibility.

okay, my wording might not have been precise enough, "keeping the
replaced item" is not my definition of "replace", but of "add" :)

I explicitly suggest to sacrifice compatibility, and gain a cleaner API.
Having a FilterOperator2, and the respective changes in all interfaces
and implementations which in/directly use it, is ugly, to say at least.

Ciao
Frank

-- 
- Frank Schönheit, Software Engineer         [email protected] -
- Sun Microsystems                      http://www.sun.com/staroffice -
- OpenOffice.org Base                       http://dba.openoffice.org -
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to