On Fri, 18 Jul 2025 at 03:01, youkidearitai <youkideari...@gmail.com> wrote:
> 2025年7月16日(水) 21:37 Jakub Zelenka <bu...@php.net>: > > > > On Tue, Jul 15, 2025 at 6:44 PM Niels Dossche <dossche.ni...@gmail.com> > wrote: > >> > >> On 15/07/2025 09:26, youkidearitai wrote: > >> > 2025年6月19日(木) 3:45 Peter Kokot <p...@php.net>: > >> >> > >> >> What about bundling Oniguruma to php-src/ext/mbstring/oniguruma > again as it once was already? This would make development easier to be > located inside php-src. However, everything put inside php-src has a > questionable future on its own. For example, to be buildable as a > standalone library and used elsewhere. > >> > > >> > Hi, > >> > > >> > Surely, I think make sense to be include inside php-src. > >> > From GitHub comment > >> > (https://github.com/php/php-src/issues/18467#issuecomment-3044192511 > ), > >> > FreeBSD will end to maintenance Oniguruma in 2026-12-01. > >> > > >> > Therefore, I think re-include Oniguruma inside php-src. > >> > > >> > Is require an RFC if re-include Oniguruma? > >> > >> Hi > >> > >> Yes. > >> > >> This also won't solve the problem. > >> The problem is that Oniguruma is currently not maintained, not that > it's unavailable. Bundling the library inside PHP does not solve that > maintenance problem. > > > > > > Well bundling effectively means that PHP teams is responsible for fixing > (at least the security) issues. So in some way it solves the problem for > users. The question is whether the maintenance burden that it adds is worth > it. > > > > Kind regards, > > > > Jakub > > Hi, all > > Thanks for response. > > Niels, Peter > I see. We dropped many extensions abandonment libraries in the past. > Maybe Oniguruma(mbregex) drop is make sense. > > > Considering that (I hope/think) most developers have moved to UTF-8 for > their encoding > > Yes, Derick. I hope that we are moving forward to Unicode too. > > > how useful is it to have a separate (and > > not-comptible-with-PCRE) regular expression engine still? > > I don't know how useful is Oniguruma(mbregex). > But seems many uses it. > https://github.com/search?q=mb_ereg+language%3APHP&type=code&l=PHP > > Anyway, I agree simple regex engine, Only PCRE. > > Jakub > > > Well bundling effectively means that PHP teams is responsible for fixing > (at least the security) issues. > > Yes, that's right. > > Therefore, I said ambiguous my position(drop support mbregex or still > support in re-include Oniguruma). > However, I want to support PCRE and drop support mbregex. > > > Regards > (Sorry for the weird way to respond) > > Yuya > -- > --------------------------- > Yuya Hamada (tekimen) > - https://tekitoh-memdhoi.info > - https://github.com/youkidearitai > ----------------------------- I still think that Oniguruma needs to be bundled to make builds simpler. Deprecating this part of the mbstring extension will take until PHP 9 to be able to remove it (at least according to current PHP practices - deprecation and removal phase). And in the meantime PHP can be at least built with Oniguruma. Otherwise, there will be a situation where PHP 8.5 will have the option to enable mbregex functionality, while Oniguruma can't be found in the distribution packages (not downloadable through packages). If these functions can be replaced with the PCRE regular expressions, that's fantastic.