Am 17.07.2025, 18:21:10 schrieb Daniel Scherzer <daniel.e.scher...@gmail.com >:
> Hi internals, > > Voting is now open for this RFC. > > * RFC: https://wiki.php.net/rfc/delayedtargetvalidation_attribute > * Discussion thread: https://externals.io/message/127702 > > Voting will end 2025-07-31 at end-of-day UTC. > > -Daniel > As one of the original attributes RFC authors, I have voted yes on this and hope it passes. its unfortunate that we need to do this, because its a bit of a hacky solution, but its entirely the vault of the original implementation, we didn't think of this. And that we didn’t think of it during the Deprecated RFC as well and already set the target validation to the max and just not do anyhting with the attribute. I think a better fix could be to delay target validation automatically to the point when the Engine consumes an attribute, but that would change the original behavior and not sure if that would get a majority, so an opt <http://opt.in>-in approach is the least bad solution to fix this shortcoming. Another solution, since this will work only with new attributes, would be more informal: that we set target=all for compiler attributes from now on, at least for attributes where we think they could expand in targets in the future. greetings Benjamin
