First of all I would like to appologise for possibly being too pedantic, but I have spotted some typos that might be considered to be fixed.
I was reading http://qa.php.net/write-test.php and I saw that the filename REATME.TESTING was mentioned in all of the test code examples. I believe this is a typo and the filename should read README.TESTING I have therefore attached the patches that fixes those typos.
While reading a README.SUBMITTING_PATCH about how to get through to you, I also spotted another typo. Patch attached.
Sorry for nitpicking.
-- Petras Kudaras aka moxliukas
Index: php-src/README.SUBMITTING_PATCH
===================================================================
RCS file: /repository/php-src/README.SUBMITTING_PATCH,v
retrieving revision 1.7
diff -u -r1.7 README.SUBMITTING_PATCH
--- php-src/README.SUBMITTING_PATCH 8 Jul 2003 09:43:39 -0000 1.7
+++ php-src/README.SUBMITTING_PATCH 22 Dec 2003 22:53:44 -0000
@@ -90,7 +90,7 @@
to include the patch as a MIME attachment even if it is short.
NOTE: only MIME attachments of type 'text/*' are accepted. The
- easiest way to acclomplish this, is to make the extension
+ easiest way to accomplish this, is to make the extension
'.txt'.
Test scripts should be included in the same email.
@@ -100,7 +100,7 @@
What happens after you submit your patch
---------------------------------------
+----------------------------------------
If your patch is easy to review and has obviously no side-effects,
it might take up to a few hours until someone commits it.
Index: php-src/ext/exif/tests/exif005.phpt =================================================================== RCS file: /repository/php-src/ext/exif/tests/exif005.phpt,v retrieving revision 1.5 diff -u -r1.5 exif005.phpt --- php-src/ext/exif/tests/exif005.phpt 16 Dec 2002 14:54:35 -0000 1.5 +++ php-src/ext/exif/tests/exif005.phpt 22 Dec 2003 22:46:57 -0000 @@ -7,7 +7,7 @@ zlib.output_compression=0 --FILE-- <?php -/* Do not change this test it is a REATME.TESTING example. +/* Do not change this test it is a README.TESTING example. * test5.jpg is a 1*1 image that contains an Exif section with ifd = 00000009h */ $image = exif_read_data(dirname(__FILE__).'/test5.jpg','',true,false);
Index: php-src/ext/standard/tests/strings/str_shuffle.phpt =================================================================== RCS file: /repository/php-src/ext/standard/tests/strings/str_shuffle.phpt,v retrieving revision 1.1 diff -u -r1.1 str_shuffle.phpt --- php-src/ext/standard/tests/strings/str_shuffle.phpt 25 Oct 2002 10:46:19 -0000 1.1 +++ php-src/ext/standard/tests/strings/str_shuffle.phpt 22 Dec 2003 22:47:43 -0000 @@ -2,7 +2,7 @@ Testing str_shuffle. --FILE-- <?php -/* Do not change this test it is a REATME.TESTING example. */ +/* Do not change this test it is a README.TESTING example. */ $s = '123'; var_dump(str_shuffle($s)); var_dump($s);
Index: php-src/ext/standard/tests/strings/strtr.phpt
===================================================================
RCS file: /repository/php-src/ext/standard/tests/strings/strtr.phpt,v
retrieving revision 1.3
diff -u -r1.3 strtr.phpt
--- php-src/ext/standard/tests/strings/strtr.phpt 25 Oct 2002 10:46:19 -0000
1.3
+++ php-src/ext/standard/tests/strings/strtr.phpt 22 Dec 2003 22:46:14 -0000
@@ -2,7 +2,7 @@
strtr() function
--FILE--
<?php
-/* Do not change this test it is a REATME.TESTING example. */
+/* Do not change this test it is a README.TESTING example. */
$trans = array("hello"=>"hi", "hi"=>"hello", "a"=>"A", "world"=>"planet");
var_dump(strtr("# hi all, I said hello world! #", $trans));
?>-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
