On February 01, 2004 12:30 pm, Andi Gutmans wrote: > I understand from the comments here that your patch wasn't very successful.
Original patch was incomplete, therefor I made 2 seperate patches (1 for php5 & 1 for php4) that augment the behaviour and fix the problem originally reported by Rasmus.
Oh OK. As I mentioned in a previous email I'm not sure this is the best way of doing the patch. It should be possible to bailout when the parse error is detected.
> Any chance you can: > a) Revert the patch. > b) Send me a short reproducing example of the combination which doesn't > currently work? I tried to include a file which has a parse error and it > did stop execution right away (which it should). I guess I didn't quite > understand which combination doesn't work.
main.php <?php include("a.php"); echo "Hello World\n"; ?>
a.php <?php $a = ' ?>
The old behaviour would print the parse error message, BUT also the "Hello World" string indicating the execution of the main script was not stopped. My argument, which others seem to share is that it should've stopped. If you disagree with this, then I'll revert the patch, otherwise the additions (see attached) should be applied, which would properly handle file not found situation of include().
I agree completely that this is a bug. When I tried to reproduce I printed 1 and didn't see it, but I re-ran my test and looked a bit closer.
Andi
-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
