pon., 23 mar 2020 o 18:58 <jan.h.boeh...@gmx.de> napisał(a): > Hi internals, > > I have opened voting on > https://wiki.php.net/rfc/userspace_operator_overloading, which allows > users > to overload operators in their own classes. >
I got two comments, a little late but always better than even later. The first thing is for operator methods when the operation is not supported I would see simply `return null;` as the right solution instead of constant, which name no one will remember. The second thing is notices which are confusing when suggesting to go and implement overloaded operator method on extension derived classes like stdClass like below: Notice: You have to implement the __add function in class stdClass to use this operator with an object in... The text of the notice is not documented in the RFC but it is implemented that way in the patch. A PHP developer is not likely gonna download the php-src source code, build environment and go with the ext/standard implementation and start adding it in C. The notice in this cases should either be different or not emitted at all. If the latter then that has to be documented I guess. Cheers, -- Michał Brzuchalski
