Am 19.02.2021 um 16:21 schrieb Sara Golemon <poll...@php.net>: > On Fri, Feb 19, 2021 at 8:04 AM Christian Schneider <cschn...@cschneid.com > <mailto:cschn...@cschneid.com>> wrote: > Indentation in var_export: > ==================== > The indentation for > var_export((object)[(object)[]]); > is off by one for nested structures: > (object) array( > '0' => # <-- extra space before index > (object) array( > and the fix would be to change > buffer_append_spaces(buf, level + 2) > to > buffer_append_spaces(buf, level + 1) > in ext/standard/var.c > > This breaks about 60 PHP tests relying on the var_export format. > > > I think shifting the indentation in var_export() could probably be done > without a major BC break. Trimming trailing whitespace would also resolve > one of my long-time annoyances with the function. > Feel free to propose that as a PR and/or an RFC.
There is a PR fixing both the indentation and removing the trailing spaces: https://github.com/php/php-src/pull/6724 Do you think this needs an RFC? - Chris
