> Now that I see their implementation again, I'm wondering if > `IntlDateTimePatternGenerator` is the right name, or we should also use > `IntlDatePatternGenerator`, which is more in line with `IntlDateFormatter`.
I was also wondering about that. I ended up going for `IntlDateTimePatternGenerator`, because ICU has that same inconsistency (`icu::DateFormat` and `icu::DateTimePatternGenerator`). I think the big argument here is discoverability - if someone is wondering about whether PHP exposes the feature from ICU, it might be harder to find it if we name it differently (and vice versa). PS: Sorry about the duplicate/badly formatted message - I am new to the concept of mailing lists. ----- Original Message ----- From: "Máté Kocsis" <kocsismat...@gmail.com> To: "Mel Dafert" <m...@dafert.at> Cc: "internals" <internals@lists.php.net> Sent: Sunday, March 28, 2021 7:45:46 PM Subject: Re: [PHP-DEV] Proposal: add IntlDateTimePatternGenerator Hi Mel, Thank you very much for working on this! I was bitten by lack of this functionality a few years ago, and I couldn't find any (good) alternative. Thus, I'm looking forward to having `IntlDateTimePatternGenerator` in ext/intl. I think it could be mentioned for those who don't open the bug report that HHVM implemented this class long ago: https://github.com/facebook/hhvm/commit/bc84daf7816e4cd268da59d535dcadfc6cf01085 Now that I see their implementation again, I'm wondering if `IntlDateTimePatternGenerator` is the right name, or we should also use `IntlDatePatternGenerator`, which is more in line with ``IntlDateFormatter`. Regards: Máté Mel Dafert <m...@dafert.at> ezt írta (időpont: 2021. márc. 28., V, 16:54): -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
