Hi Kamil, PHP warnings are tricky, error handlers may cause side effects, throw exceptions, etc. Especially, for this deprecation you'll have to handle a new "slow" path (in VM and JIT) that should return back to the main path.
Thanks. Dmitry. On Fri, Jun 11, 2021 at 3:13 PM Kamil Tekiela <tekiela...@gmail.com> wrote: > Hi Dmitry, > > Thanks for voicing your concerns. > I have started writing implementation and it is definitely challenging for > me, because I am not that experienced with PHP internals yet. > https://github.com/php/php-src/pull/7131 > > Almost every implementation requires some amount of work. I would like to > ask you for more details on why you think this particular change is > infeasible. Do you see any problems that the implementation of this > deprecation message would cause? Would it be better to wait for PHP 9.0 and > remove it without deprecation? > As I see it, we already have an error for other scalar types. For false, > we will just need to throw a deprecation notice in the same places. It > doesn't require a major rewrite of PHP engine from what I can tell. > > Regards, > Kamil >
