On 2023/01/20 11:52, Jakub Zelenka <bu...@php.net> wrote: > Reduce the diff to absolute minimum to prevent potential conflict. I think > it would be more acceptable if there was a plan that will get us there in > multiple releases rather than do one big bang change.
My draft PR currently contains 104 very small commits, one for each library that I fixed. If you like some of them, it's easy for me to submit a new PR with that selection, and then you can merge them. I'll keep the rest rebased, for some day you decide to merge the rest. That's up to you. I don't know what kind of "plan" I need to have - I clean up what needs to be cleaned up, but first, we need to decide what "there" means in "get us there". > Well we don't even know when 9.0 will be tagged so this could span to years > which might be waste of your resources just for the sake of headers. A lot of work is already done, and I keep this branch rebased on master, which is just as much work as merging, no real difference. No time saved. On the other hand, having an official branch to become 9.0 or whatever version with my patches already in, others can chime in and help with the code cleanup. > That said I think it would be maybe more sensible what I mentioned > above and that's to split the work to multiple steps over the years. I don't know what you mean by that. Cleaning up a code base is incremental work; I have 104 of those splitted steps in my branch, and many more steps may follow. This will take years, or rather: will never be finished, because code can always be improved some more. Do you mean I should work more slowly? I should submit my patches more slowly? In smaller PRs? Wait more between PRs? Before I submitted my work, I was specifically asked to submit smaller PRs with fewer commits, which I did, and the first 4 small PRs were merged, with more waiting in my queue (until my effort was stopped by Dmitry's veto). > I think it should be at least included with "php.h" to reduce the impact on > SAPI's and extensions. OK, noted, I'll amend my PR branch to move omitted #includes to php.h/php_compat.h to retain source compatibility. Max -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
