Hi On 1/20/23 17:54, Máté Kocsis wrote:
Sorry for the confusion! The PR contains an implementation for the "clone with" indeed just because it builds on top of some specifics of the 2nd proposal in the "Readonly amendments" RFC. However, the first few (4) commits are related to allowing modification of readonly properties in __clone().
Thank you. It would probably make sense to create a separate copy of the current version of the branch, possibly creating separate PR and then to drop the unrelated commits from #9497 - or alternatively picking the first 4 commits and creating a new clean PR from that. The latter is probably preferable. There's a large number of comments in the PR itself that do not relate to the feature-as-proposed-in-the-RFC.
I'm seeing that Nicolas already spelled out the unset() part in __clone(), but I think it would also be useful to have that within the example code. It's more easily missed in text. Examples are cheap :-)
Best regards Tim Düsterhus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
