On 17.3.2024 13:23:04, Marc Bennewitz wrote:
Hello internals,
I have opened the vote for the "Rounding Integers as int" RFC:
https://wiki.php.net/rfc/integer-rounding
Do to Easter weekend the vote will run for two weeks and two days
until Tue the 2nd of April 2024.
Best regards,
Marc Bennewitz
Hey Marc,
I've voted no; it should be just changed without any force_float
parameter. Just always return int when possible (and the input was int).
If users wish to have the old behaviour, they should just explicitly
cast via (float).
The effective BC break of that would be quite small if some things which
return float today now would return int. I cannot imagine many cases
where this would actually be unwanted. And as said, explicit (float)
casts are always possible.
I also dislike force_float, as it cannot just be added to a function in
any code which shall be backwards compatible to 8.3 and older. It would
just emit Uncaught Error: Unknown named parameter $force_float.
Bob
