On Mon, Jul 1, 2024 at 7:05 PM Larry Garfield <la...@garfieldtech.com> wrote:
> Hi folks. As Ilija's been polishing off hooks to get the PR merged, we've > run into two small revisions that should make life better for all > involved. One is a performance improvement that requires a very slight > error handling behavior change, and the other is enabling readonly in > selected (but probably all of the relevant) circumstances. > > I'd say we expect these to be uncontroversial, but this is PHP. :-) So I > will instead just note that it's a short RFC and open the discussion > accordingly. > > https://wiki.php.net/rfc/hook_improvements > > -- > Larry Garfield > la...@garfieldtech.com "A side effect of that optimization, however, is that we cannot proactively detect the bug above. Instead, it would result in an infinite loop, which would eventually trigger a a stack overflow." This got a small typo ("a a" at the end). This reads no different to me than infinite recursion between 2 methods. It honestly does not bother me, and any static analysis tool will be able to pick this anyway. Sounds like a free performance gain to me!
