On 18/07/2024 14:08, Christoph M. Becker wrote: > Hi all! > > I have noticed that the CODEOWNERS of php-src are apparently not synced > for all active branches[1][2]. However, it seems to me that this > doesn't make sense; if someone provides a PR against some lower branch, > the most recent CODEOWNERS may not be notified, and modifications might > be send to possibly inactive maintainers. This is particularly > confusing if the base branch of an PR will be changed; all over sudden > new reviews may be requested. > > So I suggest to sync CODEOWNERS for all active branches (and maybe even > security branches). > > What do you think? > > [1] <https://github.com/php/php-src/blob/PHP-8.2/.github/CODEOWNERS> > [2] <https://github.com/php/php-src/blob/master/.github/CODEOWNERS> > > Cheers, > Christoph
Hi I believe they should be synced indeed, although we should be careful with extensions that are dropped from PHP (e.g. imap). Those entries should remain only in 8.2 and 8.3 but not in master. Kind regards Niels
