On Fri, Aug 16, 2024, at 7:53 PM, Juliette Reinders Folmer wrote: > On 16-8-2024 17:01, Ayesh Karunaratne wrote: >> I went ahead and created PR https://github.com/php/php-src/pull/15443 along >> with tests, UPGRADE notice, etc. I think having a `get_declared_enums` >> function will be helpful. The implementation is simple and straightforward >> too. > Thanks for creating the PR Ayesh! > > I'm presuming it's too late for PHP 8.4, what with feature freeze > having come & gone this week. > > Based on the mostly supportive responses on the list, I wonder whether > an RFC is needed. If so, I'd be happy to create an initial draft (for > PHP 8.5). > > Smile, > Juliette
I would prefer to have an RFC for this, even if it's short. I'm not against it, I just think there's enough non-trivial questions (eg, impact on get_declared_classes()) that it warrants an RFC process/discussion. --Larry Garfield
