On August 16, 2024 2:59:11 AM GMT+02:00, Dennis Snell 
<dennis.sn...@automattic.com> wrote:
>
>All,
>
>
>I have submitted an RFC draft for including the proposed feature from this 
>issue. Thanks to everyone who helped me in this process. It’s my first RFC, so 
>I apologize in advance for any mistakes I’ve made in the process.
>
>
>https://wiki.php.net/rfc/decode_html
>
>
>
>
>This is proposed for a future PHP version after 8.4.
>
>
>Warmly,
>Dennis Snell
>

Hello,

I have just one nit: I think it would be better to use an enum for the 
`$context`
parameter rather than a constant.
It also feels like it ought to be nice to find some reasonable default... I'm 
sure many
programmers will see this parameter and be
unsure which value to use. There should, at the very least, be clear 
documentation with
real-world examples in which cases which one should be used.

All in all, this is definitely a welcome improvement!

Regards,
Mel

Reply via email to