On Wed, Jan 29, 2025 at 4:22 AM David CARLIER <devne...@gmail.com> wrote:
> Hi, > > Working on this PR #17440 <https://github.com/php/php-src/pull/17440>, I > wanted to ask if the BC from these two calls > were ok because : > > Before > > function socket_getsockname(Socket $socket, &$address, *&$port = null*): > bool {} > > After > > function socket_getsockname(Socket $socket, &$address, *?int &$objint = > null*): bool {} > > As it is no longer only used for port but also for. interface address > index in the case of AF_PACKET. > > Please no BC break. It's really not worth it. Cheers Jakub
