Thanks for applying my patches. When will it be applied to PHP4.3 and 5.0 tree?
With regards Kamesh Jayachandran On Tue, 26 Oct 2004 10:34:19 +0100, "Wez Furlong" <[EMAIL PROTECTED]> said: > Heh, looks like it's never ever been enabled since ext/openssl was born. > > I committed your patch; the associated bug number was 29418. > > Thanks :) > > --Wez. > > > On Mon, 25 Oct 2004 23:17:19 -0700, Kamesh Jayachandran > <[EMAIL PROTECTED]> wrote: > > Hi Wez, > > > > zend_module_entry openssl_module_entry = { > > STANDARD_MODULE_HEADER, > > "openssl", > > openssl_functions, > > PHP_MINIT(openssl), > > NULL, //supposed to be module shutdown function but marked as > > NULL even though we have MSHUTDOWN function defined. > > NULL, > > NULL, > > PHP_MINFO(openssl), > > NO_VERSION_YET, > > STANDARD_MODULE_PROPERTIES > > }; > > > > My patch for making the req.priv_key not to get dispopsed is available > > here. > > http://puggy.symonds.net/~kameshj/openssl.c.patch > > > > With regards > > Kamesh Jayachandran > > On Mon, 25 Oct 2004 16:49:17 +0100, "Wez Furlong" <[EMAIL PROTECTED]> > > said: > > > > > > > Kamesh Jayachandran wrote: > > > > During the failure openssl_csr_new is not setting req.priv_key to NULL > > > > this causes dispose function to free the req.priv_key. > > > > > > > Can I go ahead and set req.priv_key = NULL when php_openssl_make_REQ > > > > returns failure and we_made_the_key == 0? > > > > > > Please send me a diff > > > > > > > I have seen shutdown function is set to NULL even though it is defined. > > > > > > Which one? Where? > > > > > > --Wez > > > > > > > -- > > PHP Internals - PHP Runtime Development Mailing List > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php