Hi
On 1/16/26 08:20, youkidearitai wrote:
I creating a new function for strrev for grapheme cluster unit.
grapheme_strrev function.
My investigate, Sometime found mb_strrev function for userland.
However, I think create a grapheme cluster unit for strrev function.
Because multi code point in human language and emoji.
I created an RFC and Pull Request.
Feel free to comment.
https://wiki.php.net/rfc/grapheme_strrev
https://github.com/php/php-src/pull/20949
Thank you for your RFC. Aligning the feature set of the grapheme
functions with those of mbstring and the bytestring-based functions
definitely makes sense to me. I am thus in favor of the RFC.
For the RFC document itself:
You did not fill in the "RFC Impact" section. I think it can just be
"None" for each of them. The only impact is the conflict with a possibly
existing function. You already mentioned that in the breaking changes
section. Adding new functions doesn't have any relevant impact on tools
or IDEs, this is something that regularly happens.
For Future Scope it can probably also be "None"? Even if you plan to add
more grapheme functions, they are independent of grapheme_strrev.
In the References section, please add a link to the mailing list
archives of the discussion. This makes it easy for folks to find the
discussion in the future. The correct link is:
https://news-web.php.net/php.internals/129765
Best regards
Tim Düsterhus
