I didn't try it (the boxen are shipping to USA), but I did look through it; it looks like it will do the job. Once I've settled in, I'll give it a go if no one beats me to it.
It looks good to go in anyway IMO; thanks Sascha. --Wez On Wed, 27 Oct 2004 11:19:30 -0700, Andi Gutmans <[EMAIL PROTECTED]> wrote: > Wez, > > Did you try this patch? It'd be good if someone who had serialization > performance issues can verify this significantly improves it. > > Andi > > > > At 01:10 PM 10/24/2004 +0200, Sascha Schumann wrote: > > > The specific case I had was serializing an array containing a whole > > > bunch of arrays representing the data from tables in a database. I > > > don't recall how many rows there were, but the serialized data was > > > around 5 MB. This was on windows, and feels like realloc doing > > > over-time, so a fix could be something as simple as tweaking the > > > smart_str chunking code; start with a fair initial size and perhaps > > > having it double the size on each realloc. > > > > The default values you find inside php_smart_str.h are tuned > > for efficient usage of the engine's allocator. They are not > > tuned for huge real-world usage. > > > > The attached patch should change that for var.c. > > > > - Sascha > > > > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
