On 1/29/26 19:37, Ben Ramsey wrote:
On 1/22/26 09:38, LamentXU wrote:Hi internals,I am posting this to announce the start of the voting process of the RFC 'Add form feed as a whitespace character in trim, ltrim and rtrim'Wiki page: https://wiki.php.net/rfc/trim_form_feed discussion thread: https://news-web.php.net/php.internals/129706 date to end: 2026/2/6 15:30:00 UTC Thank you in advance for your participation. Cheers, Weilin DuI've voted "no" on this RFC since the RFC says the proposed PHP version is PHP 8.5, which I interpret as meaning PHP 8.6, since 8.5 was released in November.Even if PHP 8.6 is the proposed version, I still think the target version should be PHP 9.0, since this is a BC break. I mentioned my concern about this being a BC break in the discussion thread.The RFC is also clear this is a BC break. It says: > This is a **backward incompatible change**. Scripts that rely on > `trim()` *preserving* leading or trailing Form Feed characters will > be affected.I'm a little surprised by the number of folks who voted "yes" on this, despite it being very clear this is a BC break and PHP "Next" is the implied proposed version.Cheers, Ben
It looks like you changed the proposed PHP version from 8.6 to 8.5 on the same day you opened voting.[^1] IMO, this was at least a minor change (according to our Feature Proposals policy), which requires notifying the mailing list of the change and should have triggered a 7-day cool down before voting could begin.[^2]
I appreciate the work you've put into this, and I agree with the need for this change, but I'm a little worried those who voted "yes" might not have noticed the proposed version change on the RFC from PHP 8.6 to PHP 8.5.
Cheers, Ben[1]: https://wiki.php.net/rfc/trim_form_feed?do=diff&rev2%5B0%5D=1768834282&rev2%5B1%5D=1769092319&difftype=sidebyside [2]: https://github.com/php/policies/blob/main/feature-proposals.rst#cooldown-period
OpenPGP_signature.asc
Description: OpenPGP digital signature
