Hi
On 2/21/26 18:51, Christian Schneider wrote:
I would like to introduce DocComment support for function parameters:
https://wiki.php.net/rfc/parameter-doccomments
Thank you. This makes sense to me and it has a straight-forward
implementation.
Some comments regarding the RFC:
- Please add a link to the ML discussion to the “References” section:
https://news-web.php.net/php.internals/130121
- The ABI change is irrelevant: Extensions have to be recompiled for
every PHP branch and new features may not ship with 3rd-digit versions
anyways. Mentioning this is thus misleading at best (affecting
“Backwards incompatible changes”, “Proposed PHP version”, and “RFC Impact”).
- In fact, there is not even an ABI change, because the new field is
added at the end of the struct.
- Within the “Ecosystem” impact, you should probably mention that this
might require adjustments to code style / formatting guidelines and
autoformatters - or at the very least a decision needs to be made there.
Best regards
Tim Düsterhus
