Konnichiwa

Am 2026-05-16 17:19, schrieb Go Kudo:
RFC: https://wiki.php.net/rfc/opcache_static_cache
Implementation: https://github.com/php/php-src/pull/22052

Thank you for your RFC. I am seeing there already was discussion and changes to the RFC. This seems to have resulted in some inconsistencies.

The "Proposal" section still mentions "the volatile cache, used by OPcache\volatile_* […]", but these functions have been renamed. The same applies to the next bullet point for the pinned cache and to the "Why two cache backends" section. Maybe there is even more places where the old function names are referenced.

I also noticed some problems with the "Coding Standards and Naming Policy" (https://github.com/php/policies/blob/main/coding-standards-and-naming.rst). Namely:

1. The namespace should be called `Opcache` for proper PascalCase.
2. The `CacheStoreType` cases should follow PascalCase, so `OpcacheSerialized` and `PhpSerialized`. 3. There must be a `OpcacheException` base exception: `class OpcacheException extends Exception { }`.
4. `StaticCacheException` must extend from the `OpcacheException`.
5. The policy does not say anything about properties, but it is generally accepted that properties should also use camelCase instead of underscores. So it needs to be `$startupFailed` instead of `$startup_failed` and similar.

I'm still working through the full RFC and the discussion. From what I see the points above are still valid in the latest version of the RFC and the discussion. That is why I am already sending them now.

Best regards
Tim Düsterhus

Reply via email to