The patch is fine by me. It's very good idea too since it's not likely to break anyone's build whatever versions they have installed. :)
Just commit. (or if you can't, I'll do it later today)
--Jani
On Mon, 4 Apr 2005, Jon Parise wrote:
On Tue, Mar 29, 2005 at 10:43:30PM -0500, Jon Parise wrote:
On Tue, Mar 29, 2005 at 04:15:38PM +0300, Jani Taskinen wrote:
Such schemes are quite common thanks to incompatibilities between autotools versions, e. g. Subversion's buildconf equivalent accepts the names from environment, mentioning IIRC Debian installing the tools as e. g. autoconf-213.
If someone can provide a patch that works in every single OS with any possible combination of autoconf* packages installed I'll be happy to commit such patch. As long as nobody can provide such patch and PROVE it won't break things for others -> no commit.
I've read the comments and generated a second patch. This one solves my problem in a more acceptable way, by introducing two environmental variables, PHP_AUTOCONF and PHP_AUTOHEADER, which default to 'autoconf' and 'autoheader', respectively. The idea is borrowed from Subversion's buildconf equivalent (which Roman mentions above).
Apologies if this got lost amongst the effort to prepare the recent set of releases, but I'm curious whether or not people find my second patch acceptable, based on the results of the prior discussion. If not, I'll know to abandon the issue.
-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
